linux-kernel - Re: [PATCH v2 1/2] codafs: Fix build using bare-metal toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKaJLVvSHZq9eZd2uqojHb9bdLOnLhQn1X-i=YBWMXMeexrWYg@mail.gmail.com>
Date:   Tue, 11 Sep 2018 19:53:59 +0300
From:   Sam Protsenko <semen.protsenko@...aro.org>
To:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        codalist@...a.cs.cmu.edu, coda@...cmu.edu,
        Jan Harkes <jaharkes@...cmu.edu>
Cc:     Praneeth Bajjuri <praneeth@...com>,
        Paul Sokolovsky <paul.sokolovsky@...aro.org>,
        Miklos Szeredi <mszeredi@...e.cz>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Ruslan Bilovol <ruslan.bilovol@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Christoph Hellwig <hch@...radead.org>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v2 1/2] codafs: Fix build using bare-metal toolchain

On Wed, Aug 29, 2018 at 8:00 PM, Sam Protsenko
<semen.protsenko@...aro.org> wrote:
> The kernel is self-contained project and can be built with bare-metal
> toolchain. But bare-metal toolchain doesn't define __linux__. Because of
> this u_quad_t type is not defined when using bare-metal toolchain and
> codafs build fails. This patch fixes it by defining u_quad_t type
> unconditionally.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>
> ---
>  include/linux/coda.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/coda.h b/include/linux/coda.h
> index d30209b9cef8..0ca0c83fdb1c 100644
> --- a/include/linux/coda.h
> +++ b/include/linux/coda.h
> @@ -58,8 +58,7 @@ Mellon the rights to redistribute these changes without encumbrance.
>  #ifndef _CODA_HEADER_
>  #define _CODA_HEADER_
>
> -#if defined(__linux__)
>  typedef unsigned long long u_quad_t;
> -#endif
> +
>  #include <uapi/linux/coda.h>
>  #endif
> --
> 2.18.0
>

Hi guys,

It's been a while since I sent this patch. Can we please merge it if
there is no objections?

Thanks.