linux-kernel - Re: [PATCH 4.4 22/79] Smack: Mark inode instant in smack_task_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec9602b1-1c9e-58e7-85be-f98f39febaf3@schaufler-ca.com>
Date:   Tue, 11 Sep 2018 11:53:26 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        James Morris <james.morris@...rosoft.com>
Cc:     stable@...r.kernel.org,
        Sasha Levin <alexander.levin@...rosoft.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 22/79] Smack: Mark inode instant in
 smack_task_to_inode

On 9/11/2018 11:14 AM, Ben Hutchings wrote:
> On Thu, 2018-08-23 at 09:52 +0200, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Casey Schaufler <casey@...aufler-ca.com>
>>
>> [ Upstream commit 7b4e88434c4e7982fb053c49657e1c8bbb8692d9 ]
>>
>> Smack: Mark inode instant in smack_task_to_inode
>>
>> /proc clean-up in commit 1bbc55131e59bd099fdc568d3aa0b42634dbd188
> That change ("/proc clean-up") only went into 4.18 and hasn't been
> backported to stable, so does this make sense for earlier stable
> branches?

No, it does not.

>
> Ben.
>
>> resulted in smack_task_to_inode() being called before smack_d_instantiate.
>> This resulted in the smk_inode value being ignored, even while present
>> for files in /proc/self. Marking the inode as instant here fixes that.
>>
>> Signed-off-by: Casey Schaufler <casey@...aufler-ca.com>
>> Signed-off-by: James Morris <james.morris@...rosoft.com>
>> Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> ---
>>  security/smack/smack_lsm.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- a/security/smack/smack_lsm.c
>> +++ b/security/smack/smack_lsm.c
>> @@ -2260,6 +2260,7 @@ static void smack_task_to_inode(struct t
>>  	struct smack_known *skp = smk_of_task_struct(p);
>>  
>>  	isp->smk_inode = skp;
>> +	isp->smk_flags |= SMK_INODE_INSTANT;
>>  }
>>  
>>  /*
>>
>>
>>