linux-kernel - Re: linux-next boot error (2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180912063454.0620abb4@canb.auug.org.au>
Date:   Wed, 12 Sep 2018 06:34:54 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     David Howells <dhowells@...hat.com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>,
        syzbot <syzbot+762a577f56cfb1574647@...kaller.appspotmail.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Levin, Alexander" <alexander.levin@...izon.com>,
        LKML <linux-kernel@...r.kernel.org>, linux@...inikbrodowski.net,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        nikolaus.voss@...wensteinmedical.de,
        syzkaller-bugs <syzkaller-bugs@...glegroups.com>
Subject: Re: linux-next boot error (2)

Hi David,

On Tue, 11 Sep 2018 21:16:27 +0100 David Howells <dhowells@...hat.com> wrote:
>
> Andrei Vagin spotted a missing change to apparmor:
> apparmor_fs_context_parse_param() needs to return -ENOPARAM, not 0.

I will apply this fix until the proper fix arrives in the vfs tree:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Wed, 12 Sep 2018 06:27:43 +1000
Subject: [PATCH] apparmor: fix a return value

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 security/apparmor/lsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index c316d4237d94..416204ea713d 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -602,7 +602,7 @@ static int apparmor_fs_context_parse_param(struct fs_context *fc,
 
 	afc->saved_options = p;
 	afc->saved_size += 1 + len;
-	return 0;
+	return -ENOPARAM;
 }
 
 static int apparmor_sb_mountpoint(struct fs_context *fc, struct path *mountpoint,
-- 
2.19.0.rc2

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped