linux-kernel - Re: [Question] Are the trace APIs declared by "TRACE_EVENT(irq_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180911235445.3f361575@vmware.local.home>
Date:   Tue, 11 Sep 2018 23:54:45 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
        Kunxun Xie <xiekunxun@...wei.com>
Subject: Re: [Question] Are the trace APIs declared by
 "TRACE_EVENT(irq_handler_entry" allowed to be used in Ko?

On Wed, 12 Sep 2018 10:08:37 +0800
"Leizhen (ThunderTown)" <thunder.leizhen@...wei.com> wrote:

> After patch 7e066fb870fc ("tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()"),
> the trace APIs declared by "TRACE_EVENT(irq_handler_entry" can not be directly used
> by ko, because it's not explicitly exported by EXPORT_TRACEPOINT_SYMBOL_GPL or
> EXPORT_TRACEPOINT_SYMBOL.
> 
> Did we miss it? or it's not recommended to be used in ko?
> 

Why do you need it. This patch is almost 10 years old, and you are just
now finding an issue with it?

-- Steve

> 
> -------------
> 
> commit 7e066fb870fcd1025ec3ba7bbde5d541094f4ce1
> Author: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
> Date:   Fri Nov 14 17:47:47 2008 -0500
> 
>     tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()
> 
>     Impact: API *CHANGE*. Must update all tracepoint users.
> 
>     Add DEFINE_TRACE() to tracepoints to let them declare the tracepoint
>     structure in a single spot for all the kernel. It helps reducing memory
>     consumption, especially when declaring a lot of tracepoints, e.g. for
>     kmalloc tracing.
> 
>     *API CHANGE WARNING*: now, DECLARE_TRACE() must be used in headers for
>     tracepoint declarations rather than DEFINE_TRACE(). This is the sane way
>     to do it. The name previously used was misleading.
> 
>     Updates scheduler instrumentation to follow this API change.
> 
>