linux-kernel - Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180912074850.GA362@kroah.com>
Date:   Wed, 12 Sep 2018 09:48:50 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dave Jiang <dave.jiang@...el.com>
Cc:     dan.j.williams@...el.com, vishal.l.verma@...el.com,
        fan.du@...el.com, linux-nvdimm@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uio: fix is_source param for check_copy_size() in
 copy_to_iter_mcsafe()

On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote:
> copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
> to check_copy_size(). This is different than what copy_to_iter() does.
> Also, the addr parameter passed to check_copy_size() is the source so
> therefore we should be passing in "true" instead.
> 
> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
> Cc: Fan Du <fan.du@...el.com>
> Reported-by: Wenwei Tao <wenwei.tww@...baba-inc.com>
> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
> Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>
> Cc: stable <stable@...r.kernel.org>
> ---
>  include/linux/uio.h |    2 +-

I am not the maintainer of this file, sorry, please work with the -mm
developers for this.

thanks,

greg k-h