linux-kernel - Re: [PATCH 04/11] dts: qcom: Update coresight bindings for hardware ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Sep 2018 11:31:01 +0100
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     leo.yan@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        robh@...nel.org, frowand.list@...il.com,
        devicetree@...r.kernel.org, mathieu.poirier@...aro.org,
        arm@...nel.org, sudeep.holla@....com,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        "Ivan T . Ivanov" <ivan.ivanov@...aro.org>
Subject: Re: [PATCH 04/11] dts: qcom: Update coresight bindings for hardware
 ports

Hi Leo,

On 12/09/18 11:17, leo.yan@...aro.org wrote:
> Hi Suzuki,
> 
> On Tue, Sep 11, 2018 at 11:17:05AM +0100, Suzuki K Poulose wrote:
>> Switch to updated coresight bindings for hw ports
>>
>> Cc: Andy Gross <andy.gross@...aro.org>
>> Cc: David Brown <david.brown@...aro.org>
>> Cc: Ivan T. Ivanov <ivan.ivanov@...aro.org>
>> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
>> ---
>>   arch/arm64/boot/dts/qcom/msm8916.dtsi | 98 ++++++++++++++++++++++-------------
>>   1 file changed, 63 insertions(+), 35 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
>> index 7b32b89..5bed52b 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
>> @@ -1099,10 +1099,11 @@
>>   			clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
>>   			clock-names = "apb_pclk", "atclk";
>>   
>> -			port {
>> -				tpiu_in: endpoint {
>> -					slave-mode;
>> -					remote-endpoint = <&replicator_out1>;
>> +			out-ports {
> 
> Here should be in-ports for tpiu node?
> 
> BTW, if upper comment is valid, this means the DT binding doc also
> gives wrong example for tpiu node [1].

You are right on both counts.

> 
> I tested this patch with upper changing to 'in-ports', etm with perf
> mode can work well on DB410c board.
> 

Thanks a lot for the testing. I will fix both the problems.

Suzuki