linux-kernel - Re: [PATCH 02/11] dts: hisilicon: Update coresight bindings for hardware ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22fd3ec6-bde0-87c6-673b-f95a15190bda@arm.com>
Date:   Wed, 12 Sep 2018 13:42:09 +0100
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     leo.yan@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        robh@...nel.org, frowand.list@...il.com,
        devicetree@...r.kernel.org, mathieu.poirier@...aro.org,
        arm@...nel.org, sudeep.holla@....com, xuwei5@...ilicon.com,
        lipengcheng8@...wei.com
Subject: Re: [PATCH 02/11] dts: hisilicon: Update coresight bindings for
 hardware ports

Hi Leo,

On 12/09/18 11:47, leo.yan@...aro.org wrote:
> On Tue, Sep 11, 2018 at 11:17:03AM +0100, Suzuki K Poulose wrote:
>> Switch to updated coresight bindings for hw ports.
> 
> As Shawn suggested, please change subject as "arm64: dts: hi6220:
> ...."
> 

Sure, will do.

>> Cc: xuwei5@...ilicon.com
>> Cc: lipengcheng8@...wei.com
>> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
>> ---
>>   .../arm64/boot/dts/hisilicon/hi6220-coresight.dtsi | 147 ++++++++++++---------
>>   1 file changed, 85 insertions(+), 62 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-coresight.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220-coresight.dtsi
>> index 7afee5d..2202816 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-coresight.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-coresight.dtsi
> 
> [...]
> 
>> @@ -302,10 +315,12 @@
>>   
>>   			cpu = <&cpu3>;
>>   
>> -			port {
>> -				etm3_out: endpoint {
>> -					remote-endpoint =
>> -						<&acpu_funnel_in3>;
>> +			out-ports {
>> +				port {
>> +					etm3_out: endpoint {
>> +						remote-endpoint =
>> +							<&acpu_funnel_in3>;
>> +					};
>>   				};
>>   			};
>>   		};
>> @@ -319,10 +334,12 @@
>>   
>>   			cpu = <&cpu4>;
>>   
>> -			port {
>> +			out-ports {
>> +				port {
>>   				etm4_out: endpoint {
> 
> Indent?

Yes, I have fixed this locally for v2.

> 
> After applied this patch and tested on Hikey board; FWIW:
> 
> Tested-by: Leo Yan <leo.yan@...aro.org>

Thanks for the testing !

Cheers
Suzuki