linux-kernel - Re: [PATCH v2 2/5] ext4: cache NULL when both default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1dd02a3-78ea-0240-72cc-135ee26f6524@gmx.com>
Date:   Wed, 12 Sep 2018 23:04:35 +0800
From:   cgxu519 <cgxu519@....com>
To:     tytso@....edu, adilger.kernel@...ger.ca
Cc:     jack@...e.com, jaegeuk@...nel.org, yuchao0@...wei.com,
        shaggy@...nel.org, hubcap@...ibond.com, martin@...ibond.com,
        devel@...ts.orangefs.org, linux-kernel@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        jfs-discussion@...ts.sourceforge.net
Subject: Re: [PATCH v2 2/5] ext4: cache NULL when both default_acl and acl are
 NULL

On 08/31/2018 10:33 PM, Chengguang Xu wrote:
> default_acl and acl of newly created inode will be initiated
> as ACL_NOT_CACHED in vfs function inode_init_always() and later
> will be updated by calling xxx_init_acl() in specific filesystems.
> Howerver, when default_acl and acl are NULL then they keep the value
> of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl
> in this case.
>
> Signed-off-by: Chengguang Xu <cgxu519@....com>
> ---
> v1->v2:
> - Coding style change.
>
>   fs/ext4/acl.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c
> index fb50f9aa6ead..c1d570ee1d9f 100644
> --- a/fs/ext4/acl.c
> +++ b/fs/ext4/acl.c
> @@ -284,12 +284,16 @@ ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
>   		error = __ext4_set_acl(handle, inode, ACL_TYPE_DEFAULT,
>   				       default_acl, XATTR_CREATE);
>   		posix_acl_release(default_acl);
> +	} else {
> +		inode->i_default_acl = NULL;
>   	}
>   	if (acl) {
>   		if (!error)
>   			error = __ext4_set_acl(handle, inode, ACL_TYPE_ACCESS,
>   					       acl, XATTR_CREATE);
>   		posix_acl_release(acl);
> +	} else {
> +		inode->i_acl = NULL;
>   	}
>   	return error;
>   }

Hi Ted,  Andreas

Have you got chance to look at this patch?

Thanks,
Chengguang