linux-kernel - Re: [PATCH] NTB: ntb_hw_switchtec: add pre-requisites for NTB driver and misc updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Sep 2018 09:53:43 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Wesley.Sheng@...rochip.com, kurt.schwemmer@...rosemi.com,
        bhelgaas@...gle.com, corbet@....net
Cc:     linux-pci@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>
Subject: Re: [PATCH] NTB: ntb_hw_switchtec: add pre-requisites for NTB driver
 and misc updates

Thanks Wesley,

On 9/12/2018 2:55 AM, Wesley.Sheng@...rochip.com wrote:
> From: Wesley Sheng <Wesley.Sheng@...rochip.com>
> 
> 1.add pre-requisites for NTB driver
> 2.misc updates
>   change ntb hardware driver name to ntb_hw_switchtec
>   update the description of 2 partitions limit
>   add reference to Linux Documentation/ntb.txt
>   add use of term 'Command ID'
>   add use of term 'Command Return Value'
>   add a missing ')'

The commit message and patch title could use a bit of cleanup. It should
at least say you're updating the documentation, it reads as though you
are changing the driver.

Also, especially given the NTB tag in the patch title, you probably
should have CC'd the NTB List. (linux-ntb@...glegroups.com
<linux-ntb@...glegroups.com>)

> Signed-off-by: Kelvin Cao <kelvin.cao@...rochip.com>
> Signed-off-by: Wesley Yung <Wesley.Yung@...rochip.com>

Acked-by: Logan Gunthorpe <logang@...tatee.com>


Logan