linux-kernel - Re: [PATCH] workqueue: combine judgments in the loop of maybe_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180912155530.GF2966370@devbig004.ftw2.facebook.com>
Date:   Wed, 12 Sep 2018 08:55:30 -0700
From:   Tejun Heo <tj@...nel.org>
To:     liusong@....com
Cc:     jiangshanlai@...il.com, liu.song11@....com.cn,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] workqueue: combine judgments in the loop of
 maybe_create_worker

On Wed, Sep 12, 2018 at 09:58:29PM +0800, liusong@....com wrote:
> From: Liu Song <liu.song11@....com.cn>
> 
> Although the 'need_to_create_worker' has been determined to be
> true before entering the function. However, adjusting the order
> of judgment can combine two judgments in the loop. Also improve
> the matching between logical operations and function naming.
> 
> Signed-off-by: Liu Song <liu.song11@....com.cn>

idk, this doesn't really improve anything.

Thanks.

-- 
tejun