linux-kernel - Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1RoYo0VHrDfxdmJt9ns0ErTeuctH9CPG5_mg7JTwZtEQ@mail.gmail.com>
Date:   Wed, 12 Sep 2018 18:20:34 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        gregkh <gregkh@...uxfoundation.org>,
        Peter Huewe <peterhuewe@....de>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Stefan Richter <stefanr@...6.in-berlin.de>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        "Winkler, Tomas" <tomas.winkler@...el.com>,
        Artem Bityutskiy <dedekind1@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        David Miller <davem@...emloft.net>,
        Alex Williamson <alex.williamson@...hat.com>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-integrity@...r.kernel.org,
        linux1394-devel@...ts.sourceforge.net,
        USB list <linux-usb@...r.kernel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Networking <netdev@...r.kernel.org>,
        driverdevel <devel@...verdev.osuosl.org>, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

On Wed, Sep 12, 2018 at 5:33 PM Jason Gunthorpe <jgg@...pe.ca> wrote:
>
> On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote:
> > Each of these drivers has a copy of the same trivial helper function to
> > convert the pointer argument and then call the native ioctl handler.
> >
> > We now have a generic implementation of that, so use it.
> >
>
> For vtpm:
>
> Reviewed-by: Jason Gunthorpe <jgg@...lanox.com>
>
> Arnd, would you consider including a patch as part of/after this
> series to make compat_ioctl in drivers/infiniband/core/uverbs_main.c
> use this as well?  Looks like a bug too?

That should be included in patch 5 in this series. I may have skipped
some Cc there since it had too many recipients (sent only to the
mailing lists instead).

        Arnd