linux-kernel - Re: [PATCH AUTOSEL 4.18 02/88] usb: usbtest: use irqsave() in USB's complete callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180912173801.GD3821@sasha-vm>
Date:   Wed, 12 Sep 2018 17:38:02 +0000
From:   Sasha Levin <Alexander.Levin@...rosoft.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH AUTOSEL 4.18 02/88] usb: usbtest: use irqsave() in USB's
 complete callback

On Fri, Sep 07, 2018 at 07:42:23AM +0200, Greg Kroah-Hartman wrote:
>On Fri, Sep 07, 2018 at 12:35:52AM +0000, Sasha Levin wrote:
>> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
>>
>> [ Upstream commit 6f3fde684d0232e66ada3410f016a58e09a87689 ]
>>
>> The USB completion callback does not disable interrupts while acquiring
>> the lock. We want to remove the local_irq_disable() invocation from
>> __usb_hcd_giveback_urb() and therefore it is required for the callback
>> handler to disable the interrupts while acquiring the lock.
>> The callback may be invoked either in IRQ or BH context depending on the
>> USB host controller.
>> Use the _irqsave() variant of the locking primitives.
>
>All of the "use irqsave in USB's complete callback" patches are not
>stable material as they are prep work for changes that have yet to hit
>Linus's tree.
>
>So you can drop this one.

Now dropped. Thanks!