linux-kernel - Re: [PATCH v2 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180912193221.GA194302@google.com>
Date:   Wed, 12 Sep 2018 13:32:21 -0600
From:   Yu Zhao <yuzhao@...gle.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Rakesh Ughreja <rakesh.a.ughreja@...el.com>,
        Guneshwor Singh <guneshwor.o.singh@...el.com>,
        Naveen Manohar <naveen.m@...el.com>,
        Sriram Periyasamy <sriramx.periyasamy@...el.com>,
        Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@...el.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after
 RIRB allocation"

On Wed, Sep 12, 2018 at 11:20:20AM +0100, Mark Brown wrote:
> On Tue, Sep 11, 2018 at 03:12:46PM -0600, Yu Zhao wrote:
> > This reverts commit 12eeeb4f4733bbc4481d01df35933fc15beb8b19.
> > 
> > The patch doesn't fix accessing memory with null pointer in
> > skl_interrupt().
> 
> Please use normal subject lines and so on even for revert patches -
> they're patches just the same as any other.

Well, they seem pretty normal to me, and have been used by many:

  commit 82ab86e82911107ead6fc7cd73568f75bc266a57
  Author: Mark Brown <broonie@...nel.org>
  Date:   Mon Oct 30 19:40:25 2017 +0000
  
      Revert "ASoC: rt5651: Enable jack detection on JD* pins"
      
      This reverts commit 60d5a1a47b9a8381c08d2263b11ac9c757c87746.
      
      Signed-off-by: Mark Brown <broonie@...nel.org>

Anyway, I'll update them in v3.