linux-kernel - Re: [PATCH 1/2] r8169: Align ASPM/CLKREQ setting function with vendor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180913.104813.1180256346366643481.davem@davemloft.net>
Date:   Thu, 13 Sep 2018 10:48:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kai.heng.feng@...onical.com
Cc:     nic_swsd@...ltek.com, hkallweit1@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] r8169: Align ASPM/CLKREQ setting function with
 vendor driver

From: Kai-Heng Feng <kai.heng.feng@...onical.com>
Date: Wed, 12 Sep 2018 14:58:20 +0800

> There's a small delay after setting ASPM in vendor drivers, r8101 and
> r8168.
> In addition, those drivers enable ASPM before ClkReq, also change that
> to align with vendor driver.
> 
> I haven't seen anything bad becasue of this, but I think it's better to
> keep in sync with vendor driver.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

I want Heiner Kallweit to review these before I apply them.

Thanks.