linux-kernel - Re: [PATCH 4/6] afs: Differentiate VL servers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14307.1536875456@warthog.procyon.org.uk>
Date:   Thu, 13 Sep 2018 22:50:56 +0100
From:   David Howells <dhowells@...hat.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     dhowells@...hat.com, viro@...iv.linux.org.uk,
        linux-afs@...ts.infradead.org, keyrings@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] afs: Differentiate VL servers

David Howells <dhowells@...hat.com> wrote:

> +		ret = -EPROTONOSUPPORT;
> +		if (protocol != IPPROTO_UDP)
> +			goto error;

This needs to be:

		ret = -EPROTONOSUPPORT;
		if (protocol != IPPROTO_UDP && protocol != 0)
			goto error;

so that if the protocol is unspecified by the DNS upcall program, we choose
UDP.

David