linux-kernel - Re: [PATCH 4.4 34/80] enic: handle mtu change for vf properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180913071024.GG11496@kroah.com>
Date:   Thu, 13 Sep 2018 09:10:24 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Govindarajulu Varadarajan <gvaradar@...co.com>,
        "David S. Miller" <davem@...emloft.net>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.4 34/80] enic: handle mtu change for vf properly

On Wed, Sep 12, 2018 at 02:03:13AM +0100, Ben Hutchings wrote:
> On Mon, 2018-09-03 at 18:49 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Govindarajulu Varadarajan <gvaradar@...co.com>
> > 
> > [ Upstream commit ab123fe071c9aa9680ecd62eb080eb26cff4892c ]
> > 
> > When driver gets notification for mtu change, driver does not handle it for
> > all RQs. It handles only RQ[0].
> > 
> > Fix is to use enic_change_mtu() interface to change mtu for vf.
> [...]
> 
> This causes a assertion failure (noisy error logging, but not an oops)
> when the driver is probed.  This was fixed upstream by:
> 
> commit cb5c6568867325f9905e80c96531d963bec8e5ea
> Author: Govindarajulu Varadarajan <gvaradar@...co.com>
> Date:   Mon Jul 30 09:56:54 2018 -0700
> 
>     enic: do not call enic_change_mtu in enic_probe
> 
> which is now needed on the 3.18, 4.4, and 4.9 stable branches.

Ah, I didn't realize it was really needed on the older branches as well,
due to the lack of the mtu settings on those kernel trees in this
driver.

I've now backported it there, thanks.

greg k-h