linux-kernel - Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffcf1b3a-b66c-6e0e-3e7a-da092e9d1894@linaro.org>
Date:   Wed, 12 Sep 2018 13:43:42 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     robh+dt@...nel.org, broonie@...nel.org, mark.rutland@....com,
        lgirdwood@...il.com, bgoswami@...eaurora.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        vkoul@...nel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core


>>
>> There are two parts for device to be ready to talk at bus level:
>> 1> power up and reset,
>> 2> enumerate and assign a logical address by the slimbus controller.
>>
>> First part as you said is already done in probe.
>> When second part happens when status callback is invoked, that is when the
>> slimdevice is ready for any kind of communication at bus level.
> 
> I see.  I still think it's hacky to conduct start-up procedures when
> all the SS requested was status.  Perhaps it needs a new API call
> init()?

When we added these callbacks the purpose of this was to allow drivers 
to do specific setup/teardown.

AFIAU, even-though if we add init(), SLIMbus would still call it just 
before or after status which to me is redundant ATM.
Its up to slim driver what it exactly whats to do with status, in some 
cases this can involve setting up the device.

>