linux-kernel - RE: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO2PR07MB255146DAA1B87BB046E64BAECD1A0@CO2PR07MB2551.namprd07.prod.outlook.com>
Date:   Thu, 13 Sep 2018 10:15:19 +0000
From:   Damian Kos <dkos@...ence.com>
To:     Andrzej Hajda <a.hajda@...sung.com>,
        David Airlie <airlied@...ux.ie>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Archit Taneja <architt@...eaurora.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Sean Paul <sean@...rly.run>, Sandy Huang <hjc@...k-chips.com>,
        Heiko Stübner <heiko@...ech.de>,
        Quentin Schulz <quentin.schulz@...tlin.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>
CC:     Przemyslaw Gaj <pgaj@...ence.com>,
        Lukasz Tyrala <ltyrala@...ence.com>,
        Scott Telford <stelford@...ence.com>,
        Artur Jedrysek <jartur@...ence.com>,
        Piotr Sroka <piotrs@...ence.com>
Subject: RE: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk
 dpi/dp driver

Thank you, Andrzej! I was a bit afraid that our patches are a bit too messy and thus ignored 😊
Anyway, this patch (1/5) should be the last one that will cause such chaos in the DRM area.

Regards,
Damian

-----Original Message-----
From: Andrzej Hajda <a.hajda@...sung.com> 
Sent: Thursday, September 13, 2018 12:01
To: Damian Kos <dkos@...ence.com>; David Airlie <airlied@...ux.ie>; Rob Herring <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>; Archit Taneja <architt@...eaurora.org>; Laurent Pinchart <Laurent.pinchart@...asonboard.com>; Gustavo Padovan <gustavo@...ovan.org>; Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>; Sean Paul <sean@...rly.run>; Sandy Huang <hjc@...k-chips.com>; Heiko Stübner <heiko@...ech.de>; Quentin Schulz <quentin.schulz@...tlin.com>; dri-devel@...ts.freedesktop.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-rockchip@...ts.infradead.org
Cc: Przemyslaw Gaj <pgaj@...ence.com>; Lukasz Tyrala <ltyrala@...ence.com>; Scott Telford <stelford@...ence.com>; Artur Jedrysek <jartur@...ence.com>; Piotr Sroka <piotrs@...ence.com>
Subject: Re: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver

EXTERNAL MAIL


Hi Damian,

Quite late but.

On 28.08.2018 12:24, Damian Kos wrote:
> - Extracted common fields from cdn_dp_device to a new cdns_mhdp_device
>   structure which will be used by two separate drivers later on.
> - Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format,
>   video_info) from cdn-dp-core.c to cdn-dp-reg.h.
> - Changed prefixes from cdn_dp to cdns_mhdp
>     cdn -> cdns to match the other Cadence's drivers
>     dp -> mhdp to distinguish it from a "just a DP" as the IP underneath
>       this registers map can be a HDMI (which is internally different,
>       but the interface for commands, events is pretty much the same).
> - Modified cdn-dp-core.c to use the new driver structure and new function
>   names.
>
> Signed-off-by: Damian Kos <dkos@...ence.com>

Many changes, hard to review. Anyway:

Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

 --
Regards
Andrzej