linux-kernel - Re: [PATCH v2 03/17] compat_ioctl: use correct compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871s9x1wy1.fsf@linux.intel.com>
Date:   Thu, 13 Sep 2018 14:03:18 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>, viro@...iv.linux.org.uk
Cc:     linux-fsdevel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Frederic Barrat <fbarrat@...ux.vnet.ibm.com>,
        Andrew Donnellan <andrew.donnellan@....ibm.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Frank Haverkamp <haver@...ux.vnet.ibm.com>,
        "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers

Arnd Bergmann <arnd@...db.de> writes:

> A handful of drivers all have a trivial wrapper around their ioctl
> handler, but don't call the compat_ptr() conversion function at the
> moment. In practice this does not matter, since none of them are used
> on the s390 architecture and for all other architectures, compat_ptr()
> does not do anything, but using the new generic_compat_ioctl_ptrarg
> helper makes it more correct in theory, and simplifies the code.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Felipe Balbi <felipe.balbi@...ux.intel.com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)