linux-kernel - Re: [PATCH] MAINTAINERS: Add PPC contacts for PCI core error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94b8929d44af6dd965600b7d159458312d500582.camel@russell.cc>
Date:   Thu, 13 Sep 2018 12:26:55 +1000
From:   Russell Currey <ruscur@...sell.cc>
To:     Bjorn Helgaas <helgaas@...nel.org>, linux-pci@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, sbobroff@...ux.ibm.com
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        linux-kernel@...r.kernel.org, oohall@...il.com
Subject: Re: [PATCH] MAINTAINERS: Add PPC contacts for PCI core error
 handling

On Wed, 2018-09-12 at 11:58 -0500, Bjorn Helgaas wrote:
> On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > The original PCI error recovery functionality was for the powerpc-specific
> > IBM EEH feature.  PCIe subsequently added some similar features, including
> > AER and DPC, that can be used on any architecture.
> > 
> > We want the generic PCI core error handling support to work with all of
> > these features.  Driver error recovery callbacks should be independent of
> > which feature the platform provides.
> > 
> > Add the generic PCI core error recovery files to the powerpc EEH
> > MAINTAINERS entry so the powerpc folks will be copied on changes to the
> > generic PCI error handling strategy.
> 
> I really want to make sure the powerpc folks are plugged into any PCI core
> error handling discussions.  Please let me know if there's a better way
> than this patch, or if there are other people who should be added.

I think this patch is definitely a good idea.

Alongside this (whether you want to include it in your patch or not, Bjorn),
Sam Bobroff should replace myself as maintainer.  He's been very active in fixing,
reworking and reviewing in EEH land and will probably do a better job of keeping
his finger on the pulse of the generic PCI error handling code than I did.

- Russell

> 
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > ---
> >  MAINTAINERS |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 7e10ba65bfe4..d6699597fd89 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11202,6 +11202,10 @@ PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
> >  M:	Russell Currey <ruscur@...sell.cc>
> >  L:	linuxppc-dev@...ts.ozlabs.org
> >  S:	Supported
> > +F:	Documentation/PCI/pci-error-recovery.txt
> > +F:	drivers/pci/pcie/aer.c
> > +F:	drivers/pci/pcie/dpc.c
> > +F:	drivers/pci/pcie/err.c
> >  F:	Documentation/powerpc/eeh-pci-error-recovery.txt
> >  F:	arch/powerpc/kernel/eeh*.c
> >  F:	arch/powerpc/platforms/*/eeh*.c
> >