linux-kernel - RE: [PATCH v2] efi: take size of partition entry from GPT header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2db38b2d1af34ab9b653c665d08872f1@AcuMS.aculab.com>
Date:   Fri, 14 Sep 2018 09:01:48 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Eugene Korenevsky' <ekorenevsky@...il.com>
CC:     "kzak@...hat.com" <kzak@...hat.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: RE: [PATCH v2] efi: take size of partition entry from GPT header

From: Eugene Korenevsky
> Sent: 13 September 2018 20:48
> 
> > I suspect you also need a sanity check that the value isn't too small
> > or stupidly large.
> 
> What would be the criterion for too large entries?

Anything larger than the maximum size of the full GPT table
would be a start.
Even something like 64k would stop later calculations going wrong.
I presume there is a check elsewhere that the GPT table entries
are all inside the disk area that was read?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)