linux-kernel - Re: 答复: Re: [PATCH] tty: max3100: Fix oops while 'cat/proc/tty/driver/ttyMAX'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 14 Sep 2018 13:28:11 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     chen.lin5@....com.cn
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org
Subject: Re: 答复: Re: [PATCH] tty: max3100: Fix oops while 'cat/proc/tty/driver/ttyMAX'

On 09/13/2018, 08:32 AM, chen.lin5@....com.cn wrote:
>        
> 
> but 'get_mctrl' is already protected by  the upper layer by spin lock,
> so, will the races happen?
> 
> 
> for example: in /drivers/tty/serial/serial_core.c 
> 
>               spin_lock_irq(&uport->lock);
> 
>               result |= uport->ops->get_mctrl(uport);
> 
>               spin_unlock_irq(&uport->lock);

Right, but creation and destroy of the workqueue is not locked as far as
I can see. Am I missing something?

thanks,.
-- 
js
suse labs