linux-kernel - Re: [PATCH] misc: sgi-gru: fix fall-through annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180914124334.GA2205@hpe.com>
Date:   Fri, 14 Sep 2018 07:43:34 -0500
From:   Dimitri Sivanich <sivanich@....com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Dimitri Sivanich <sivanich@....com>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: sgi-gru: fix fall-through annotations

Acked-by: Dimitri Sivanich <sivanich@....com>

On Thu, Sep 13, 2018 at 01:53:18PM -0500, Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
> 
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/misc/sgi-gru/grukservices.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 0307690..4b23d58 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -634,7 +634,7 @@ static int send_noop_message(void *cb, struct gru_message_queue_desc *mqd,
>  			break;
>  		case CBSS_PAGE_OVERFLOW:
>  			STAT(mesq_noop_page_overflow);
> -			/* fallthru */
> +			/* fall through */
>  		default:
>  			BUG();
>  		}
> @@ -792,7 +792,7 @@ static int send_message_failure(void *cb, struct gru_message_queue_desc *mqd,
>  		break;
>  	case CBSS_PAGE_OVERFLOW:
>  		STAT(mesq_page_overflow);
> -		/* fallthru */
> +		/* fall through */
>  	default:
>  		BUG();
>  	}
> -- 
> 2.7.4
>