linux-kernel - Re: [PATCH 1/2] watchdog: sama5d4: fix timeout-sec usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0953b2f9-83b1-b57b-2a26-fa0527c8a548@roeck-us.net>
Date:   Fri, 14 Sep 2018 06:37:04 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Romain Izard <romain.izard.pro@...il.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Marcus Folkesson <marcus.folkesson@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] watchdog: sama5d4: fix timeout-sec usage

On 09/14/2018 03:13 AM, Romain Izard wrote:
> When using watchdog_init_timeout to update the default timeout value,
> an error means that there is no "timeout-sec" in the relevant device
> tree node.
> 
> This should not prevent binding of the driver to the device.
> 
> Fixes: 976932e40036 ("watchdog: sama5d4: make use of timeout-secs provided in devicetree")
> Signed-off-by: Romain Izard <romain.izard.pro@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/sama5d4_wdt.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
> index 255169916dbb..1e93c1b0e3cf 100644
> --- a/drivers/watchdog/sama5d4_wdt.c
> +++ b/drivers/watchdog/sama5d4_wdt.c
> @@ -247,11 +247,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev)
>   		}
>   	}
>   
> -	ret = watchdog_init_timeout(wdd, wdt_timeout, &pdev->dev);
> -	if (ret) {
> -		dev_err(&pdev->dev, "unable to set timeout value\n");
> -		return ret;
> -	}
> +	watchdog_init_timeout(wdd, wdt_timeout, &pdev->dev);
>   
>   	timeout = WDT_SEC2TICKS(wdd->timeout);
>   
>