linux-kernel - Re: [PATCH 23/50] io_edgeport: switch to ->get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180914135842.GK1362@localhost>
Date:   Fri, 14 Sep 2018 15:58:42 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 23/50] io_edgeport: switch to ->get_serial()

On Thu, Sep 13, 2018 at 03:40:22AM +0100, Al Viro wrote:
> From: Al Viro <viro@...iv.linux.org.uk>
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
>  drivers/usb/serial/io_edgeport.c | 37 ++++++++++++++++---------------------
>  1 file changed, 16 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
> index 97c69d373ca6..4ca31c0e4174 100644
> --- a/drivers/usb/serial/io_edgeport.c
> +++ b/drivers/usb/serial/io_edgeport.c
 
> @@ -1667,17 +1663,12 @@ static int edge_ioctl(struct tty_struct *tty,
>  					unsigned int cmd, unsigned long arg)
>  {
>  	struct usb_serial_port *port = tty->driver_data;
> -	DEFINE_WAIT(wait);

hmm, why was there no gcc warning about this leftover?

>  	struct edgeport_port *edge_port = usb_get_serial_port_data(port);
>  
>  	switch (cmd) {
>  	case TIOCSERGETLSR:
>  		dev_dbg(&port->dev, "%s TIOCSERGETLSR\n", __func__);
>  		return get_lsr_info(edge_port, (unsigned int __user *) arg);
> -
> -	case TIOCGSERIAL:
> -		dev_dbg(&port->dev, "%s TIOCGSERIAL\n", __func__);
> -		return get_serial_info(edge_port, (struct serial_struct __user *) arg);
>  	}
>  	return -ENOIOCTLCMD;
>  }

Reviewed-by: Johan Hovold <johan@...nel.org>