linux-kernel - Re: [PATCHv3 2/2] btrfs: change remove_extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180914141646.GG5847@twin.jikos.cz>
Date:   Fri, 14 Sep 2018 16:16:46 +0200
From:   David Sterba <dsterba@...e.cz>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     dsterba@...e.com, jbacik@...com, clm@...com,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 2/2] btrfs: change remove_extent_mapping to be void
 function

On Thu, Sep 13, 2018 at 11:01:15AM +0800, zhong jiang wrote:
> remove_extent_mapping use the variable "ret" for return value,
> but it is not modified after initialzation. Further, I find that
> any of the callers do not handle the return value, so it is safe
> to drop the unneeded "ret" and make it to be void function.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Reviewed-by: David Sterba <dsterba@...e.com>