linux-kernel - [PATCH] selinux: ss: use match_string() helper to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 14 Sep 2018 22:54:12 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <paul@...l-moore.com>, <sds@...ho.nsa.gov>, <eparis@...isplace.org>
CC:     <james.morris@...rosoft.com>, <sgrover@...eaurora.org>,
        <kyeongdon.kim@....com>, <selinux@...ho.nsa.gov>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH] selinux: ss: use match_string() helper  to simplify the code

match_string() returns the index of an array for a matching string,
which can be used intead of open coded implementation.

Signed-off-by: zhong jiang <zhongjiang@...wei.com>
---
 security/selinux/ss/services.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 12e4143..aa9fc35 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -1461,14 +1461,14 @@ static int security_context_to_sid_core(struct selinux_state *state,
 		return -ENOMEM;
 
 	if (!state->initialized) {
-		int i;
+		int index;
 
-		for (i = 1; i < SECINITSID_NUM; i++) {
-			if (!strcmp(initial_sid_to_string[i], scontext2)) {
-				*sid = i;
-				goto out;
-			}
+		index = match_string(initial_sid_to_string, SECINITSID_NUM, scontext2);
+		if (index >= 0) {
+			*sid = index;
+			goto out;
 		}
+
 		*sid = SECINITSID_KERNEL;
 		goto out;
 	}
-- 
1.7.12.4