linux-kernel - [PATCH] bus: fsl-mc: use match_string() helper to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1536937404-31455-1-git-send-email-zhongjiang@huawei.com>
Date:   Fri, 14 Sep 2018 23:03:24 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <stuyoder@...il.com>, <laurentiu.tudor@....com>
CC:     <linux-kernel@...r.kernel.org>
Subject: [PATCH] bus: fsl-mc: use match_string() helper to simplify the code

match_string() returns the index of an array for a matching string,
which can be used intead of open coded implementation.

Signed-off-by: zhong jiang <zhongjiang@...wei.com>
---
 drivers/bus/fsl-mc/fsl-mc-allocator.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl-mc-allocator.c
index e906ecfe..7ecc89c 100644
--- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
+++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
@@ -160,16 +160,16 @@ static int __must_check object_type_to_pool_type(const char *object_type,
 						 enum fsl_mc_pool_type
 								*pool_type)
 {
-	unsigned int i;
+	int ret;
 
-	for (i = 0; i < ARRAY_SIZE(fsl_mc_pool_type_strings); i++) {
-		if (strcmp(object_type, fsl_mc_pool_type_strings[i]) == 0) {
-			*pool_type = i;
-			return 0;
-		}
+	ret = match_string(fsl_mc_pool_type_strings,
+			     ARRAY_SIZE(fsl_mc_pool_type_strings), object_type);
+	if (ret >= 0) {
+		*pool_type = ret;
+		return 0;
 	}
 
-	return -EINVAL;
+	return ret;
 }
 
 int __must_check fsl_mc_resource_allocate(struct fsl_mc_bus *mc_bus,
-- 
1.7.12.4