linux-kernel - Re: [PATCH 17/50] usb-serial: begin switching to ->[sg]et

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180914152636.GX1362@localhost>
Date:   Fri, 14 Sep 2018 17:26:36 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     Johan Hovold <johan@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/50] usb-serial: begin switching to ->[sg]et_serial()

On Fri, Sep 14, 2018 at 04:23:52PM +0100, Al Viro wrote:
> On Fri, Sep 14, 2018 at 03:39:30PM +0200, Johan Hovold wrote:
> > > +	if (port->serial->type->get_serial)
> > > +		return port->serial->type->get_serial(tty, ss);
> > > +	return -ENOIOCTLCMD;
> > > +}
> > > +
> > > +static int serial_set_serial(struct tty_struct *tty, struct serial_struct *ss)
> > > +{
> > > +	struct usb_serial_port *port = tty->driver_data;
> > 
> > And here.
> > 
> > > +	if (port->serial->type->set_serial)
> > > +		return port->serial->type->get_serial(tty, ss);
> 
> ... and another cut'n'paste braino - it's set_serial, of course.

Bah, I thought I'd checked them all. :)

Thanks,
Johan