linux-kernel - Re: [PATCH] usb: gadget: udc: atmel: handle at91sam9rl PMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90ccdf34-149e-b4b7-d6a9-9ebee241918c@microchip.com>
Date:   Fri, 14 Sep 2018 20:14:24 +0300
From:   Cristian Birsan <cristian.birsan@...rochip.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Felipe Balbi <balbi@...nel.org>
CC:     <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: udc: atmel: handle at91sam9rl PMC



On 10.09.2018 23:12, Alexandre Belloni wrote:
> The at91sam9rl PMC is not quite the same as the at91sam9g45 one and now has
> its own compatible string. Add support for that.
> 
> Fixes: 217bace8e548 ("ARM: dts: fix PMC compatible")
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

It looks good to me.

Acked-by: Cristian Birsan <cristian.birsan@...rochip.com>

> ---
>   drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 17147b8c771e..8f267be1745d 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -2017,6 +2017,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
>   
>   	udc->errata = match->data;
>   	udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9g45-pmc");
> +	if (IS_ERR(udc->pmc))
> +		udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9rl-pmc");
>   	if (IS_ERR(udc->pmc))
>   		udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9x5-pmc");
>   	if (udc->errata && IS_ERR(udc->pmc))
>