linux-kernel - Re: [PATCH v4 RESEND 2/5] KVM: x86: hyperv: optimize 'all cpus' case in kvm_hv_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8e97259-cef7-48a5-cf0d-c75b2fd1c515@redhat.com>
Date:   Fri, 14 Sep 2018 19:32:36 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>, kvm@...r.kernel.org
Cc:     Radim Krčmář <rkrcmar@...hat.com>,
        Roman Kagan <rkagan@...tuozzo.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>,
        Wanpeng Li <wanpeng.li@...mail.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 RESEND 2/5] KVM: x86: hyperv: optimize 'all cpus' case
 in kvm_hv_flush_tlb()

On 22/08/2018 12:18, Vitaly Kuznetsov wrote:
>  	cpumask_clear(&hv_current->tlb_lush);
>  
> +	if (all_cpus) {
> +		kvm_make_vcpus_request_mask(kvm,
> +				    KVM_REQ_TLB_FLUSH | KVM_REQUEST_NO_WAKEUP,
> +				    NULL, &hv_current->tlb_lush);
> +		goto ret_success;
> +	}
> +


The cpumask_clear can be pushed below the if.  Queued with that change.

Paolo