lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Sep 2018 13:13:00 +0800 From: zhong jiang <zhongjiang@...wei.com> To: David Miller <davem@...emloft.net> CC: <edumazet@...gle.com>, <kuznet@....inr.ac.ru>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCHv2] net: ipv4: Use BUG_ON directly instead of a if condition followed by BUG On 2018/9/14 1:42, David Miller wrote: > From: zhong jiang <zhongjiang@...wei.com> > Date: Tue, 11 Sep 2018 21:13:13 +0800 > >> The if condition can be removed if we use BUG_ON directly. >> The issule is detected with the help of Coccinelle. >> >> Signed-off-by: zhong jiang <zhongjiang@...wei.com> > Taking Simon's feedback into consideration... > > I very often see changes like this and have to check the implementation > of BUG_ON() et al. to make sure it evaluates it's arguments even when > debugging is disabled. > > Even if it is always guaranteed to do so, like me people will be unsure > forever and have to check. > > That makes auditing code and validating things more time consuming and > hard. > > I also think the code as written now looks a lot nicer. > > So I'm not applying this, sorry. > > . > Get it. Thank you for your explanation. Sincerely, zhong jiang
Powered by blists - more mailing lists