linux-kernel - Re: [PATCH 29/48] perf callchain: Maintain libunwind's address space in map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180914190006.GA18677@krava>
Date:   Fri, 14 Sep 2018 21:00:06 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Andi Kleen <andi@...stfloor.org>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>
Subject: Re: [PATCH 29/48] perf callchain: Maintain libunwind's address space
 in map_groups

On Fri, Sep 14, 2018 at 03:15:47PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Sep 13, 2018 at 02:54:31PM +0200, Jiri Olsa escreveu:
> > Currently the address_space was kept in thread struct but it's more
> > appropriate to keep it in map_groups as it's maintained throughout
> > exec's with timestamps.  Also we should not flush the address space
> > after exec since it still can be accessed when used with an indexed
> > data file.
> > 
> > Cc: Frederic Weisbecker <fweisbec@...il.com>
> > Link: http://lkml.kernel.org/n/tip-hjryh6x2yfnrz8g0djhez24z@git.kernel.org
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> >  tools/perf/util/map.h                    |  5 ++++-
> >  tools/perf/util/thread.h                 |  1 -
> >  tools/perf/util/unwind-libunwind-local.c | 28 ++++++++++++++----------
> >  tools/perf/util/unwind-libunwind.c       |  9 ++++----
> >  tools/perf/util/unwind.h                 |  7 +++---
> >  5 files changed, 29 insertions(+), 21 deletions(-)
> > 
> > diff --git a/tools/perf/util/map.h b/tools/perf/util/map.h
> > index 02c6f6962eb1..b1efe57b8563 100644
> > --- a/tools/perf/util/map.h
> > +++ b/tools/perf/util/map.h
> > @@ -65,10 +65,13 @@ struct maps {
> >  
> >  struct map_groups {
> >  	struct maps	 maps;
> > -	struct machine	 *machine;
> > +	struct machine	*machine;
> >  	refcount_t	 refcnt;
> >  	u64		 timestamp;
> >  	struct list_head list;
> 
> Hey, avoid these distractions, this doesn't change anything and besides

it bothers me.. ;-)

jirka