linux-kernel - Re: [PATCH] i2c: synquacer: fix fall-through annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Sep 2018 08:07:20 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Wolfram Sang <wsa@...-dreams.de>
Cc:     linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: synquacer: fix fall-through annotation

On 13 September 2018 at 20:59, Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

> ---
>  drivers/i2c/busses/i2c-synquacer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-synquacer.c b/drivers/i2c/busses/i2c-synquacer.c
> index 915f5ed..2184b7c 100644
> --- a/drivers/i2c/busses/i2c-synquacer.c
> +++ b/drivers/i2c/busses/i2c-synquacer.c
> @@ -404,7 +404,7 @@ static irqreturn_t synquacer_i2c_isr(int irq, void *dev_id)
>                 if (i2c->state == STATE_READ)
>                         goto prepare_read;
>
> -               /* fallthru */
> +               /* fall through */
>
>         case STATE_WRITE:
>                 if (bsr & SYNQUACER_I2C_BSR_LRB) {
> --
> 2.7.4
>