linux-kernel - Re: [PATCH 3/5] media: platform: dwc: Add DW MIPI DPHY core and platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201809151702.5u06O0Qt%fengguang.wu@intel.com>
Date:   Sat, 15 Sep 2018 17:23:02 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Luis Oliveira <Luis.Oliveira@...opsys.com>
Cc:     kbuild-all@...org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, all-jpinto-org-pt02@...opsys.com,
        Luis Oliveira <Luis.Oliveira@...opsys.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jacob Chen <jacob-chen@...wrt.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Keiichi Watanabe <keiichiw@...omium.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Todor Tomov <todor.tomov@...aro.org>
Subject: Re: [PATCH 3/5] media: platform: dwc: Add DW MIPI DPHY core and
 platform

Hi Luis,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Luis-Oliveira/media-platform-Add-DesignWare-MIPI-CSI2-Host-placeholder/20180915-163514
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sh 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/media/platform/dwc/dw-dphy-rx.c: In function 'dw_dphy_read':
>> drivers/media/platform/dwc/dw-dphy-rx.c:147:5: warning: 'dphy2' may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (dphy1 != dphy2)
        ^

vim +/dphy2 +147 drivers/media/platform/dwc/dw-dphy-rx.c

   132	
   133	u32 dw_dphy_read(struct dw_dphy_rx *dphy, u64 address)
   134	{
   135		u32 dphy1, dphy2;
   136	
   137		dphy1 = ioread32(dphy->base_address + address);
   138	
   139		if (dphy->lanes_config == CTRL_4_LANES)
   140			goto end;
   141	
   142		if (address == R_CSI2_DPHY_TST_CTRL0)
   143			dphy2 = ioread32(dphy->base_address + R_CSI2_DPHY2_TST_CTRL0);
   144		else if (address == R_CSI2_DPHY_TST_CTRL1)
   145			dphy2 = ioread32(dphy->base_address + R_CSI2_DPHY2_TST_CTRL1);
   146	
 > 147		if (dphy1 != dphy2)
   148			pr_err("Values read different for each dphy\n");
   149	
   150	end:
   151		return dphy1;
   152	}
   153	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (49563 bytes)