linux-kernel - RE: [PATCH v4 4/8] usb: dwc3: implement stream transfer timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN3PR0201MB0993B7CC13E3042415127FE0A7180@BN3PR0201MB0993.namprd02.prod.outlook.com>
Date:   Sat, 15 Sep 2018 13:20:18 +0000
From:   Anurag Kumar Vulisha <anuragku@...inx.com>
To:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "v.anuragkumar@...il.com" <v.anuragkumar@...il.com>
Subject: RE: [PATCH v4 4/8] usb: dwc3: implement stream transfer timeout

Hi Thinh,

>>
>> @@ -2403,6 +2424,13 @@ static void
>dwc3_gadget_endpoint_transfer_in_progress(struct dwc3_ep *dep,
>>  			stop = true;
>>  	}
>>
>> +	/*
>> +	 * Delete the timer that was started in __dwc3_gadget_kick_transfer()
>> +	 * for stream capable endpoints.
>> +	 */
>> +	if (dep->stream_capable)
>> +		del_timer(&dep->stream_timeout_timer);
>> +
>>  	dwc3_gadget_ep_cleanup_completed_requests(dep, event, status);
>>
>>  	if (stop) {
>> @@ -2487,6 +2515,11 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,
>>  		}
>>  		break;
>>  	case DWC3_DEPEVT_STREAMEVT:
>> +		if (event->status == DEPEVT_STREAMEVT_FOUND)
>> +			del_timer(&dep->stream_timeout_timer);
>> +		else
>> +			dev_dbg(dwc->dev, "unable to find suitable stream");
>
>This debug message is already printed in the driver tracepoint. There's no need to
>print it here. Also, I don't think Felipe will accept adding new dev_dbg() after removing
>all of them and converting them to tracepoints.
>

I agree with you, thanks for correcting. Will remove the debug prints and resend the patches

Thanks,
Anurag Kumar Vulisha