linux-kernel - Re: [PATCH] media: platform: remove redundant null pointer check before of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 16 Sep 2018 10:43:38 -0500
From:   Benoit Parrot <bparrot@...com>
To:     zhong jiang <zhongjiang@...wei.com>
CC:     <mchehab@...nel.org>, <linux-media@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: platform: remove redundant null pointer check
 before of_node_put

Zhong,

Thank you for the patch.

zhong jiang <zhongjiang@...wei.com> wrote on Sun [2018-Sep-16 21:16:51 +0800]:
> of_node_put has taken the null pinter check into account. So it is

s/pinter/pointer/

> safe to remove the duplicated check before of_node_put.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

with the above change,

Reviewed-by: Benoit Parrot <bparrot@...com>

> ---
>  drivers/media/platform/ti-vpe/cal.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
> index cc052b2..5f9d4e0 100644
> --- a/drivers/media/platform/ti-vpe/cal.c
> +++ b/drivers/media/platform/ti-vpe/cal.c
> @@ -1747,14 +1747,10 @@ static int of_cal_create_instance(struct cal_ctx *ctx, int inst)
>  	}
>  
>  cleanup_exit:
> -	if (remote_ep)
> -		of_node_put(remote_ep);
> -	if (sensor_node)
> -		of_node_put(sensor_node);
> -	if (ep_node)
> -		of_node_put(ep_node);
> -	if (port)
> -		of_node_put(port);
> +	of_node_put(remote_ep);
> +	of_node_put(sensor_node);
> +	of_node_put(ep_node);
> +	of_node_put(port);
>  
>  	return ret;
>  }
> -- 
> 1.7.12.4
>