linux-kernel - Re: [PATCH 1/4] Staging: wlan-ng: Solved Coding Style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 16 Sep 2018 22:08:26 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Pablo Pellecchia <pablo9891@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Staging: wlan-ng: Solved Coding Style issues

On Sun, Sep 16, 2018 at 04:39:11PM -0300, Pablo Pellecchia wrote:
> Solved parenthesis alignment issues throw by checkpatch.pl
> 
> Signed-off-by: Pablo Pellecchia <pablo9891@...il.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 40 ++++++++++++++++++--------------------
>  1 file changed, 19 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index d4cf09b11e33..38bf555a8d3e 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -234,8 +234,8 @@ static int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
>  	int result = 0;
>  
>  	result = prism2_domibset_uint32(wlandev,
> -		DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID,
> -		key_index);
> +					DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID,
> +					key_index);

And now you violate the line length rule :(

Which is why the code looks like it does, what you should really do is
fix up that horridly long variable name.  That will fix this properly.
Can you do that instead?

thanks,

greg k-h