linux-kernel - Re: [PATCH v7 3/5] venus: firmware: register separate platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201809160905.7uXFZmpw%fengguang.wu@intel.com>
Date:   Sun, 16 Sep 2018 09:13:29 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vikash Garodia <vgarodia@...eaurora.org>
Cc:     kbuild-all@...org, stanimir.varbanov@...aro.org,
        hverkuil@...all.nl, mchehab@...nel.org, robh@...nel.org,
        mark.rutland@....com, andy.gross@...aro.org, arnd@...db.de,
        bjorn.andersson@...aro.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, devicetree@...r.kernel.org,
        acourbot@...omium.org, vgarodia@...eaurora.org
Subject: Re: [PATCH v7 3/5] venus: firmware: register separate
 platform_device for firmware loader

Hi Stanimir,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vikash-Garodia/Venus-updates-PIL/20180915-165454
base:   git://linuxtv.org/media_tree.git master
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/media//platform/qcom/venus/firmware.c: In function 'venus_firmware_init':
>> drivers/media//platform/qcom/venus/firmware.c:175:8: error: too few arguments to function 'of_dma_configure'
     ret = of_dma_configure(&pdev->dev, np);
           ^~~~~~~~~~~~~~~~
   In file included from drivers/media//platform/qcom/venus/firmware.c:22:0:
   include/linux/of_device.h:58:5: note: declared here
    int of_dma_configure(struct device *dev,
        ^~~~~~~~~~~~~~~~

vim +/of_dma_configure +175 drivers/media//platform/qcom/venus/firmware.c

   149	
   150	int venus_firmware_init(struct venus_core *core)
   151	{
   152		struct platform_device_info info;
   153		struct platform_device *pdev;
   154		struct device_node *np;
   155		int ret;
   156	
   157		np = of_get_child_by_name(core->dev->of_node, "video-firmware");
   158		if (!np)
   159			return 0;
   160	
   161		memset(&info, 0, sizeof(info));
   162		info.fwnode = &np->fwnode;
   163		info.parent = core->dev;
   164		info.name = np->name;
   165		info.dma_mask = DMA_BIT_MASK(32);
   166	
   167		pdev = platform_device_register_full(&info);
   168		if (IS_ERR(pdev)) {
   169			of_node_put(np);
   170			return PTR_ERR(pdev);
   171		}
   172	
   173		pdev->dev.of_node = np;
   174	
 > 175		ret = of_dma_configure(&pdev->dev, np);
   176		if (ret) {
   177			dev_err(core->dev, "dma configure fail\n");
   178			goto err_unregister;
   179		}
   180	
   181		core->fw.dev = &pdev->dev;
   182		core->no_tz = true;
   183	
   184		of_node_put(np);
   185	
   186		return 0;
   187	
   188	err_unregister:
   189		platform_device_unregister(pdev);
   190		of_node_put(np);
   191		return ret;
   192	}
   193	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (66537 bytes)