linux-kernel - Re: [PATCH -next] iio: potentiometer: mcp4018: merge calls to of_match_device and of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180916103657.10cfb5ed@archlinux>
Date:   Sun, 16 Sep 2018 10:36:57 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Peter Rosin <peda@...ntia.se>
Cc:     YueHaibing <yuehaibing@...wei.com>, knaack.h@....de,
        lars@...afoo.de, pmeerw@...erw.net, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH -next] iio: potentiometer: mcp4018: merge calls to
 of_match_device and of_device_get_match_data

On Sat, 15 Sep 2018 13:35:06 +0200
Peter Rosin <peda@...ntia.se> wrote:

> On 2018-09-15 12:52, YueHaibing wrote:
> > Drop call to of_match_device, which is subsumed by the subsequent
> > call to of_device_get_match_data.  The code becomes simpler, and a
> > temporary variable can be dropped.
> > 
> > Found by coccinelle.
> > 
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>  
> 
> Acked-by: Peter Rosin <peda@...ntia.se>
Similar change already in place from Julia Lawall back in May but
looks like that just missed the last set for the merge window
after I managed to loose it and only picked up again when Peter
pointed it out in August.

However, something odd is going on as these are not currently in
next.

Ah, looks line staging-next was updated 2 days ago and last linux-next
is just before that.  So I'm afraid you hit some very unfortunate
timing or this would have been there when you were looking.

Thanks,

Jonathan

> 
> Cheers,
> Peter