linux-kernel - Re: [PATCH] iio: adc: max9611: Avoid implicit enum conversion warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Sep 2018 10:53:51 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH] iio: adc: max9611: Avoid implicit enum conversion
 warning

On Fri, 14 Sep 2018 22:25:11 -0700
Nathan Chancellor <natechancellor@...il.com> wrote:

> Clang warns when an enumerated type is implicitly converted to another.
> 
> drivers/iio/adc/max9611.c:292:16: warning: implicit conversion from
> enumeration type 'enum max9611_conf_ids' to different enumeration type
> 'enum max9611_csa_gain' [-Wenum-conversion]
>                         *csa_gain = gain_selectors[i];
>                                   ~ ^~~~~~~~~~~~~~~~~
> 1 warning generated.
> 
> Change the type of the variable 'gain_selectors' to int so that Clang
> understands this is expected behavior.
> 
> Reported-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
How does this interact with the patch that Stefan Agner sent for
the same issue last week?

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=b1ec0802503820ccbc894aadfd2a44da20232f5e

Thanks,

Jonathan

> ---
>  drivers/iio/adc/max9611.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c
> index 0538ff8c4ac1..3c358b16a8fa 100644
> --- a/drivers/iio/adc/max9611.c
> +++ b/drivers/iio/adc/max9611.c
> @@ -275,7 +275,7 @@ static int max9611_read_csa_voltage(struct max9611_dev *max9611,
>  				    u16 *adc_raw,
>  				    enum max9611_csa_gain *csa_gain)
>  {
> -	enum max9611_conf_ids gain_selectors[] = {
> +	int gain_selectors[] = {
>  		CONF_SENSE_1x,
>  		CONF_SENSE_4x,
>  		CONF_SENSE_8x