linux-kernel - Re: [RFC v10 PATCH 1/3] mm: mmap: zap pages with read mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <578efe1c-0de0-d71d-ac14-cf5b74e2a713@linux.alibaba.com>
Date:   Mon, 17 Sep 2018 12:49:49 -0700
From:   Yang Shi <yang.shi@...ux.alibaba.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     mhocko@...nel.org, ldufour@...ux.vnet.ibm.com, vbabka@...e.cz,
        kirill@...temov.name, akpm@...ux-foundation.org,
        dave.hansen@...el.com, oleg@...hat.com, srikar@...ux.vnet.ibm.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC v10 PATCH 1/3] mm: mmap: zap pages with read mmap_sem in
 munmap



On 9/15/18 2:21 AM, Matthew Wilcox wrote:
> On Sat, Sep 15, 2018 at 04:34:57AM +0800, Yang Shi wrote:
>> Suggested-by: Michal Hocko <mhocko@...nel.org>
>> Suggested-by: Kirill A. Shutemov <kirill@...temov.name>
>> Suggested-by: Matthew Wilcox <willy@...radead.org>
> Reviewed-by: Matthew Wilcox <willy@...radead.org>
>
> Looks good!  Thanks for sticking with this patch series.

Thanks for reviewing this patch series. I'm going to wait for one or two 
days to see whether anyone else has more comments before I have the 
spelling error fixed.

Yang

>
> Minor spelling fixes:
>
>> -	/*
>> -	 * Remove the vma's, and unmap the actual pages
>> -	 */
>> +	/* Detatch vmas from rbtree */
> "Detach"
>
>> +	/*
>> +	 * mpx unmap need to be handled with write mmap_sem. It is safe to
>> +	 * deal with it before unmap_region().
>> +	 */
> 	 * mpx unmap needs to be called with mmap_sem held for write.
> 	 * It is safe to call it before unmap_region()
>
>> +	ret = __do_munmap(mm, start, len, &uf, downgrade);
>> +	/*
>> +	 * Returning 1 indicates mmap_sem is down graded.
>> +	 * But 1 is not legal return value of vm_munmap() and munmap(), reset
>> +	 * it to 0 before return.
>> +	 */
> "downgraded" is one word.