linux-kernel - Re: [PATCH 3/6] xenbus: dispatch per-domU watch event to per-domU xenwatch thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Sep 2018 16:09:43 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Cc:     jgross@...e.com, paul.durrant@...rix.com, wei.liu2@...rix.com,
        konrad.wilk@...cle.com, roger.pau@...rix.com,
        srinivas.eeda@...cle.com
Subject: Re: [PATCH 3/6] xenbus: dispatch per-domU watch event to per-domU
 xenwatch thread

On 9/14/18 3:34 AM, Dongli Zhang wrote:
>  
> +static int xs_watch_insert_event(struct xs_watch_event *event, domid_t domid)
> +{
> +	struct mtwatch_domain *domain;
> +	int ret = -1;

-ENODEV maybe?

-boris

> +
> +	rcu_read_lock();
> +
> +	domain = mtwatch_find_domain(domid);
> +	if (!domain) {
> +		rcu_read_unlock();
> +		return ret;
> +	}
> +
> +	spin_lock(&domain->events_lock);
> +	if (domain->state == MTWATCH_DOMAIN_UP) {
> +		list_add_tail(&event->list, &domain->events);
> +		wake_up(&domain->events_wq);
> +		ret = 0;
> +	}
> +	spin_unlock(&domain->events_lock);
> +
> +	rcu_read_unlock();
> +
> +	return ret;
> +}
> +
>