linux-kernel - Re: [PATCH 2/2] IB/mlx4: Add port and TID to MAD debug print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201809180427.HZdNM73B%fengguang.wu@intel.com>
Date:   Tue, 18 Sep 2018 04:15:32 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Håkon Bugge <Haakon.Bugge@...cle.com>
Cc:     kbuild-all@...org, Doug Ledford <dledford@...hat.com>,
        yishaih@...lanox.com, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, jgg@...pe.ca,
        jackm@....mellanox.co.il
Subject: Re: [PATCH 2/2] IB/mlx4: Add port and TID to MAD debug print

Hi Håkon,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.19-rc4 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/H-kon-Bugge/IB-mlx4-Enable-debug-print-of-SMPs/20180917-232956
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/infiniband/hw/mlx4/mad.c:46:0:
   drivers/infiniband/hw/mlx4/mad.c: In function 'ib_process_mad':
>> drivers/infiniband/hw/mlx4/mlx4_ib.h:57:21: warning: format '%x' expects argument of type 'unsigned int', but argument 10 has type 'long long unsigned int' [-Wformat=]
    #define pr_fmt(fmt) "<" MLX4_IB_DRV_NAME "> %s: " fmt, __func__
                        ^
   include/linux/dynamic_debug.h:127:35: note: in expansion of macro 'pr_fmt'
      __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
                                      ^~~~~~
   include/linux/printk.h:340:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
   drivers/infiniband/hw/mlx4/mad.c:811:3: note: in expansion of macro 'pr_debug'
      pr_debug("received MAD: port:%d slid:%d sqpn:%d "
      ^~~~~~~~
   drivers/infiniband/hw/mlx4/mad.c:812:48: note: format string is defined here
        "dlid_bits:%d dqpn:%d wc_flags:0x%x tid:%08x cls:%x mtd:%x atr:%x\n",
                                                ~~~^
                                                %08llx

vim +57 drivers/infiniband/hw/mlx4/mlx4_ib.h

b1d8eb5a Jack Morgenstein 2012-06-19  53  
b1d8eb5a Jack Morgenstein 2012-06-19  54  #ifdef pr_fmt
b1d8eb5a Jack Morgenstein 2012-06-19  55  #undef pr_fmt
b1d8eb5a Jack Morgenstein 2012-06-19  56  #endif
b1d8eb5a Jack Morgenstein 2012-06-19 @57  #define pr_fmt(fmt)	"<" MLX4_IB_DRV_NAME "> %s: " fmt, __func__
b1d8eb5a Jack Morgenstein 2012-06-19  58  

:::::: The code at line 57 was first introduced by commit
:::::: b1d8eb5a213640f1be98a90e73a241d15b70045c IB/mlx4: Add debug prints

:::::: TO: Jack Morgenstein <jackm@....mellanox.co.il>
:::::: CC: Roland Dreier <roland@...estorage.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (65199 bytes)