linux-kernel - RE: [PATCH 3/3] ARM: dts: am335x: add support for Moxa UC-2102 open platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <TY2PR0101MB252677F596F874B9CA11EE34E21E0@TY2PR0101MB2526.apcprd01.prod.exchangelabs.com>
Date:   Mon, 17 Sep 2018 07:38:57 +0000
From:   SZ Lin (林上智) <SZ.Lin@...a.com>
To:     Rob Herring <robh@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Tony Lindgren <tony@...mide.com>,
        Benoît Cousson <bcousson@...libre.com>,
        Wes Huang (黃淵河) <Wes.Huang@...a.com>,
        Fero JD Zhou (周俊達) <FeroJD.Zhou@...a.com>
Subject: RE: [PATCH 3/3] ARM: dts: am335x: add support for Moxa UC-2102 open
 platform

Hi,

<snip>
 
> The 2102 is a superset of the 2101? If so, the 2102 should come first.
> If not, this should probably be 2 separate entries.
> 

Nope, they use different SoC models and PMICs. I'll resend them separately in next version.

Thanks for guidance.

> > +&tps {
> > +	vcc1-supply = <&vbat>;
> > +	vcc2-supply = <&vbat>;
> > +	vcc3-supply = <&vbat>;
> > +	vcc4-supply = <&vbat>;
> > +	vcc5-supply = <&vbat>;
> > +	vcc6-supply = <&vbat>;
> > +	vcc7-supply = <&vbat>;
> > +	vccio-supply = <&vbat>;
> > +
> > +	regulators {
> > +		vrtc_reg: regulator@0 {
> 
> Without a reg property, you shouldn't have unit addresses.

I would like to ask why shouldn't we keep unit address with "regulator-always-on;" reg property?

SZ

> 
> 
> > +			regulator-always-on;
> > +		};
> > +
> > +		vio_reg: regulator@1 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vdd1_reg: regulator@2 {
> > +			/* VDD_MPU voltage limits 0.95V - 1.26V with +/-4% tolerance */
> > +			regulator-name = "vdd_mpu";
> > +			regulator-min-microvolt = <912500>;
> > +			regulator-max-microvolt = <1378000>;
> > +			regulator-boot-on;
> > +			regulator-always-on;
> > +		};
> > +
> > +		vdd2_reg: regulator@3 {
> > +			/* VDD_CORE voltage limits 0.95V - 1.1V with +/-4% tolerance */
> > +			regulator-name = "vdd_core";
> > +			regulator-min-microvolt = <912500>;
> > +			regulator-max-microvolt = <1150000>;
> > +			regulator-boot-on;
> > +			regulator-always-on;
> > +		};
> > +
> > +		vdd3_reg: regulator@4 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vdig1_reg: regulator@5 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vdig2_reg: regulator@6 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vpll_reg: regulator@7 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vdac_reg: regulator@8 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vaux1_reg: regulator@9 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vaux2_reg: regulator@10 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vaux33_reg: regulator@11 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		vmmc_reg: regulator@12 {
> > +			compatible = "regulator-fixed";
> > +			regulator-name = "vmmc_reg";
> > +			regulator-min-microvolt = <3300000>;
> > +			regulator-max-microvolt = <3300000>;
> > +			regulator-always-on;
> > +		};
> > +	};
> > +};
> > +
> > +&mac {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&cpsw_default>;
> > +	dual_emac = <1>;
> > +	status = "okay";
> > +};
> > +
> > +&cpsw_emac0 {
> > +	status = "okay";
> > +	phy_id = <&davinci_mdio>, <0x4>;
> > +	phy-mode = "rmii";
> > +	dual_emac_res_vlan = <1>;
> > +};
> > +
> > +&cpsw_emac1 {
> > +	status = "okay";
> > +	phy_id = <&davinci_mdio>, <0x5>;
> > +	phy-mode = "rmii";
> > +	dual_emac_res_vlan = <2>;
> > +};
> > +
> > +&mmc1 {
> > +	pinctrl-names = "default";
> > +	vmmc-supply = <&vmmcsd_fixed>;
> > +	bus-width = <4>;
> > +	pinctrl-0 = <&mmc0_pins_default>;
> > +	cd-gpios = <&gpio3 14 GPIO_ACTIVE_HIGH>;
> > +	wp-gpios = <&gpio3 18 GPIO_ACTIVE_HIGH>;
> > +	status = "okay";
> > +};
> > --
> > 2.19.0.rc1
> >