linux-kernel - Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Sep 2018 10:33:48 +0100
From:   Jonathan Cameron <jonathan.cameron@...wei.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     <viro@...iv.linux.org.uk>, <linux-fsdevel@...r.kernel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
        <qat-linux@...el.com>, <linux-crypto@...r.kernel.org>,
        <linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <linaro-mm-sig@...ts.linaro.org>, <amd-gfx@...ts.freedesktop.org>,
        <linux-input@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <linux-rdma@...r.kernel.org>, <linux-nvdimm@...ts.01.org>,
        <linux-nvme@...ts.infradead.org>, <linux-pci@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <sparclinux@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-fbdev@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
        <linux-btrfs@...r.kernel.org>, <ceph-devel@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 05/17] compat_ioctl: move more drivers to
 generic_compat_ioctl_ptrarg

On Wed, 12 Sep 2018 17:08:52 +0200
Arnd Bergmann <arnd@...db.de> wrote:

> The .ioctl and .compat_ioctl file operations have the same prototype so
> they can both point to the same function, which works great almost all
> the time when all the commands are compatible.
> 
> One exception is the s390 architecture, where a compat pointer is only
> 31 bit wide, and converting it into a 64-bit pointer requires calling
> compat_ptr(). Most drivers here will ever run in s390, but since we now
> have a generic helper for it, it's easy enough to use it consistently.
> 
> I double-checked all these drivers to ensure that all ioctl arguments
> are used as pointers or are ignored, but are not interpreted as integer
> values.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

For IIO part.

Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Thanks,
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index a062cfddc5af..22844b94b0e9 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1630,7 +1630,7 @@ static const struct file_operations iio_buffer_fileops = {
>  	.owner = THIS_MODULE,
>  	.llseek = noop_llseek,
>  	.unlocked_ioctl = iio_ioctl,
> -	.compat_ioctl = iio_ioctl,
> +	.compat_ioctl = generic_compat_ioctl_ptrarg,
>  };
>