linux-kernel - Re: [PATCH AUTOSEL 4.9 20/57] media: sta2x11: Add video_device and vb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7b48f4f81e249ee0d9b1d558d5285d09a4c9000.camel@collabora.com>
Date:   Mon, 17 Sep 2018 08:50:27 -0300
From:   Ezequiel Garcia <ezequiel@...labora.com>
To:     Sasha Levin <Alexander.Levin@...rosoft.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Hans Verkuil <hans.verkuil@...co.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Subject: Re: [PATCH AUTOSEL 4.9 20/57] media: sta2x11: Add video_device and
 vb2_queue locks

Hi Sasha,

On Mon, 2018-09-17 at 03:03 +0000, Sasha Levin wrote:
> From: Ezequiel Garcia <ezequiel@...labora.com>
> 
> [ Upstream commit cd63c0288fd760ce7de247fba618e2bbcfc0c35c ]
> 
> Currently, this driver does not serialize its video4linux
> ioctls, which is a bug, as race conditions might appear.
> 
> In addition, video_device and vb2_queue locks are now both
> mandatory. Add them, and implement wait_prepare and
> wait_finish.
> 
> To stay on the safe side, this commit uses a single mutex
> for both locks. Better latency can be obtained by separating
> these if needed.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>
> Signed-off-by: Hans Verkuil <hans.verkuil@...co.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>

Hm, I am not so sure this patch should go to -stable,
as it's not fixing a real bug we've seen out there.

Regards,
Eze