linux-kernel - [RESEND] drbd: avoid clang warning about pointless switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4ffc2255-2ae2-60d4-703e-151979efe7ab@gmx.de>
Date:   Mon, 17 Sep 2018 14:54:34 +0200
From:   Philipp Klocke <Phil_K97@....de>
To:     philipp.reisner@...bit.com, lars.ellenberg@...bit.com,
        arnd@...db.de
Cc:     drbd-dev@...ts.linbit.com, nicolas.dichtel@...nd.com,
        davem@...emloft.net, linux-kernel@...r.kernel.org,
        lukas.bulwahn@...il.com
Subject: [RESEND] drbd: avoid clang warning about pointless switch statement

The drbd code causes warnings that we cannot easily disable when
building with clang:

In file included from drivers/block/drbd/drbd_debugfs.c:10:
In file included from drivers/block/drbd/drbd_int.h:48:
In file included from include/linux/drbd_genl_api.h:53:
In file included from include/linux/genl_magic_struct.h:237:
include/linux/drbd_genl.h:300:1: warning: no case matching constant
switch condition '0'

There is nothing wrong with the code, and adding 'default:' labels
in the right place is enough to let clang shut up about the warning.

Fixes: ec2c35ac1ea2 ("drbd: prepare the transition from connector to
genetlink")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
--
was sent on Feb. 1, 2017, 4:55 p.m. UTC by Arnd Bergmann
was acked but not merged
resend
---
 include/linux/genl_magic_struct.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/genl_magic_struct.h
b/include/linux/genl_magic_struct.h
index 6270a56e5edc..c6fbafb834f1 100644
--- a/include/linux/genl_magic_struct.h
+++ b/include/linux/genl_magic_struct.h
@@ -190,6 +190,7 @@ static inline void ct_assert_unique_operations(void)
 {
     switch (0) {
 #include GENL_MAGIC_INCLUDE_FILE
+    default:
         ;
     }
 }
@@ -208,6 +209,7 @@ static inline void
ct_assert_unique_top_level_attributes(void)
 {
     switch (0) {
 #include GENL_MAGIC_INCLUDE_FILE
+    default:
         ;
     }
 }
@@ -218,6 +220,7 @@ static inline void ct_assert_unique_ ## s_name ##
_attributes(void)    \
 {                                    \
     switch (0) {                            \
         s_fields                        \
+        default:                        \
             ;                        \
     }                                \
 }