linux-kernel - Re: [PATCH AUTOSEL 4.14 52/87] nfp: fail probe if serial or interface id is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180917070317.19c09e88@cakuba.netronome.com>
Date:   Mon, 17 Sep 2018 07:03:17 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Sasha Levin <Alexander.Levin@...rosoft.com>
Cc:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH AUTOSEL 4.14 52/87] nfp: fail probe if serial or
 interface id is missing

On Mon, 17 Sep 2018 03:02:55 +0000, Sasha Levin wrote:
> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> 
> [ Upstream commit 18aa5b180f00a10c2f63944b4f0ab116bf8ea19b ]
> 
> On some platforms with broken ACPI tables we may not have access
> to the Serial Number PCIe capability.  This capability is crucial
> for us for switchdev operation as we use serial number as switch ID,
> and for communication with management FW where interface ID is used.
> 
> If we can't determine the Serial Number we have to fail device probe.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>

If the problem occurs the driver would usually fail to probe anyway
(e.g. due to missing SR-IOV capability), just without providing any
clear message why.  So the patch is not of huge importance, but I'm 
not opposed to back porting it.

I should've put this info in the commit message, my bad.