linux-kernel - Re: [PATCH] net: hp100: fix always-true check for link up state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180917.075825.1597877157605714597.davem@davemloft.net>
Date:   Mon, 17 Sep 2018 07:58:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     perex@...ex.cz, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hp100: fix always-true check for link up state

From: Colin King <colin.king@...onical.com>
Date: Fri, 14 Sep 2018 17:39:53 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> The operation ~(p100_inb(VG_LAN_CFG_1) & HP100_LINK_UP) returns a value
> that is always non-zero and hence the wait for the link to drop always
> terminates prematurely.  Fix this by using a logical not operator instead
> of a bitwise complement.  This issue has been in the driver since
> pre-2.6.12-rc2.
> 
> Detected by CoverityScan, CID#114157 ("Logical vs. bitwise operator")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied and queued up for -stable.